Use "peer" schema for unknown providers at /routing/v1/providers #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The /routing/v1/providers/ endpoint now reports unknown schema as "peer", and omits the Protocol. Testing was manual testing using example in issue. Fixes #147
willscott
approved these changes
Aug 26, 2023
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=====================================
Coverage 6.44% 6.44%
=====================================
Files 11 11
Lines 1443 1442 -1
=====================================
Hits 93 93
+ Misses 1345 1344 -1
Partials 5 5
☔ View full report in Codecov by Sentry. |
lidel
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /routing/v1/providers/ endpoint now reports unknown schema as "peer", and omits the Protocol.
Testing was manual testing using example in issue.
Fixes #147