Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start proxying metadata requests #63

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Start proxying metadata requests #63

merged 1 commit into from
Jan 23, 2023

Conversation

ischasny
Copy link
Collaborator

@ischasny ischasny commented Jan 23, 2023

  • Proxy metadata requests that are used for double hashed lookups
  • The data is scattered across the same list of backends as is used for finds
  • Returns the first found metadata instead of gathering across all responses

Fixes #60

@ischasny ischasny closed this Jan 23, 2023
@ischasny ischasny reopened this Jan 23, 2023
server.go Outdated Show resolved Hide resolved
find.go Outdated Show resolved Hide resolved
find.go Outdated Show resolved Hide resolved
find.go Outdated Show resolved Hide resolved
find.go Outdated Show resolved Hide resolved
find.go Outdated Show resolved Hide resolved
find.go Outdated Show resolved Hide resolved
find.go Outdated Show resolved Hide resolved
find.go Outdated Show resolved Hide resolved
@ischasny
Copy link
Collaborator Author

@masih done fixes - please re-review

Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the redundant counter LGTM

find.go Show resolved Hide resolved
find.go Outdated Show resolved Hide resolved
find.go Show resolved Hide resolved
Start proxying a new metadata endpoint that is used for double hashed lookups. Queries are scattered / gathered across the same list of backends as for finds.
@ischasny ischasny merged commit a8468a8 into main Jan 23, 2023
@ischasny ischasny deleted the ivan/add-metadata-route branch January 23, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose API to GET encrypted /metadata/<key>
2 participants