Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block unknown publishers with per-provider publisher policy #2527

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gammazero
Copy link
Collaborator

@gammazero gammazero commented Feb 20, 2024

For providers that already have a known publisher, create a publisher policy that allows only the known publisher to publish advertisements for the provider.

Depends on #2526

This is draft for now, to delay deploying it for until IPNI future is somewhat clearer.

For providers that already have a known publisher, create a publisher policy that allows only the known publisher to publish advertisements for the provider.
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a69247) 44.68% compared to head (94367f7) 44.68%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2527   +/-   ##
=======================================
  Coverage   44.68%   44.68%           
=======================================
  Files          87       87           
  Lines       11007    11007           
=======================================
  Hits         4919     4919           
  Misses       5497     5497           
  Partials      591      591           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero requested a review from masih February 20, 2024 04:07
@@ -41,8 +41,105 @@
"Policy": {
"Allow": true,
"Except": null,
"Publish": true,
"PublishExcept": null
"Publish": false,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Setting "Publish": false, blocks all unknown publishers. This prevents an unknown publisher from publishing/signing advertisements for a provider that has a different peerID.

This also prevents ingesting ads from a new provider that has a different peerID, and such a publisher would need to notify the IPNI operators to explicitly allow the publisher. Existing providers will need to notify IPNI operators if they change their publisher's peer ID.

Please consider the administrative aspects of this before blocking unknown publishers.

@gammazero gammazero marked this pull request as draft February 20, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants