Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port fixes from no-graphsync branch #2583

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Port fixes from no-graphsync branch #2583

merged 4 commits into from
Apr 2, 2024

Conversation

gammazero
Copy link
Collaborator

Context

Fixed a problem where very log ad chains, with frequent updates, were being redundantly processed by multiple workers during the building of the ordered provider ad stacks.

Proposed Changes

  • Do not process ad chain if not done with previous for provider
  • Improved log messages

Tests

Modified existing tests to work with changed logic

Revert Strategy

Change is safe to revert.

- Do not process ad chain if not done with previous for provider
- Improved log messages
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 66.10169% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 44.42%. Comparing base (7326008) to head (995608d).
Report is 7 commits behind head on main.

Files Patch % Lines
internal/ingest/ingest.go 76.47% 18 Missing and 6 partials ⚠️
internal/registry/registry.go 0.00% 13 Missing ⚠️
command/daemon.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2583      +/-   ##
==========================================
- Coverage   45.00%   44.42%   -0.58%     
==========================================
  Files          95       93       -2     
  Lines       11320    11221      -99     
==========================================
- Hits         5094     4985     -109     
- Misses       5623     5633      +10     
  Partials      603      603              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero merged commit 5cad965 into main Apr 2, 2024
10 checks passed
@gammazero gammazero deleted the port-fixes-from-no-gs branch April 2, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants