Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle context concelation during ingestion #2592

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

gammazero
Copy link
Collaborator

In some places context cancelation was not handled during ingestion. This caused the indexer to be unresponsive to a shutdown request. This change will include context cancelation when selecting to read or write channels.

Adds additional debug logging.

In some places context cancelation was not handled during ingestion. This caused the indexer to be unresponsive to a shutdown request. This change will include context cancelation when selecting to read or write channels.

Adds additional debug logging.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 44.73%. Comparing base (021ab38) to head (e35cb13).

Files Patch % Lines
internal/ingest/linksystem.go 77.77% 4 Missing ⚠️
internal/ingest/ingest.go 88.23% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2592      +/-   ##
==========================================
+ Coverage   44.63%   44.73%   +0.10%     
==========================================
  Files          95       95              
  Lines       11268    11296      +28     
==========================================
+ Hits         5029     5053      +24     
- Misses       5635     5639       +4     
  Partials      604      604              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero merged commit 6bbb360 into main Apr 3, 2024
9 checks passed
@gammazero gammazero deleted the ctx-cancel-ingest branch April 3, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants