Fix out of bounds panic in registery #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When registering or updating the registry with provider information that does not have provider addresses or publisher addresses, an out of bounds panic could happen because it was assumed that the provider info whould at least have provider addresses. This is not assumed now.
gammazero
force-pushed
the
fix-registry-panic
branch
from
12bf447
to
8e3c95e
Compare
willscott
reviewed
Apr 4, 2022
| log.Warnw("Register provider with no provider or publisher addresses", | ||
| "provider", info.AddrInfo.ID, "publisher", info.Publisher) | ||
| } else { | ||
| info.PublisherAddr = info.AddrInfo.Addrs[0] |
There was a problem hiding this comment.
file a low importance bug to be able to support multiple addresses round-robin :)
willscott
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When registering or updating the registry with provider information that does not have provider addresses or publisher addresses, an out-of-bounds panic could happen because it was assumed that the provider info would at least have provider addresses.
This is not assumed now. If the situation is detected it is logged.