Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and document the core/transforms.py module #141

Closed
riley-harper opened this issue Jun 28, 2024 · 0 comments · Fixed by #148
Closed

Refactor and document the core/transforms.py module #141

riley-harper opened this issue Jun 28, 2024 · 0 comments · Fixed by #148
Labels
documentation Improvements or additions to documentation refactoring

Comments

@riley-harper
Copy link
Contributor

This module has a very large function generate_transforms() with several other functions defined inside of it. It's fairly difficult to understand this function. I'd like to refactor the functions so that they're each defined at the module level and document each of them.
@riley-harper riley-harper added refactoring documentation Improvements or additions to documentation labels Jun 28, 2024
riley-harper added a commit that referenced this issue Jun 28, 2024
@riley-harper
[#141] Refactor core.transforms.generate_transforms().get_transforms()
11a6b1a 
Now it no longer captures variables from the generate_transforms() function, so
we should be ready to move it up to the module level.
riley-harper added a commit that referenced this issue Jun 28, 2024
@riley-harper
[#141] Pull get_transforms() out of generate_transforms()
67b381c 
I've made this private since it's intended for module use only.
riley-harper added a commit that referenced this issue Jun 28, 2024
@riley-harper
[#141] Refactor core.transforms.generate_transforms().parse_feature_s…
c2da3a3 
…elections()

Pass arguments into the function instead of capturing them from the
environment.
riley-harper added a commit that referenced this issue Jun 28, 2024
@riley-harper
[#141] Pull parse_feature_selection() out of generate_transforms()
54b139b
@riley-harper riley-harper mentioned this issue Aug 27, 2024
Merged
riley-harper added a commit that referenced this issue Aug 27, 2024
@riley-harper
[#141] Use a more descriptive variable name in core.transforms._get_t…
9b3b233 
…ransforms()
riley-harper added a commit that referenced this issue Aug 27, 2024
@riley-harper
[#141] Test and document the "skip" attribute for feature selection t…
ada39ea 
…ransforms
riley-harper added a commit that referenced this issue Aug 27, 2024
@riley-harper
[#141] Add a docstring for core.transforms.generate_transforms()
378125e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor core.transforms.generate_transforms() for ease of reading ipums/hlink
1 participant
@riley-harper