Improve model_exploration step 2 output #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k_step_train_test_models
…n_and_test_models
The "Evaluating model performance..." print statements are too chatty for runs with a large threshold matrix.
This contains some information which could be helpful. Let's keep it around.
ccdavis
approved these changes
Oct 9, 2024
| ) -> list[list[pyspark.sql.DataFrame]]: | ||
| """ | ||
| Get a list of random splits of the prepped_data into two DataFrames. | ||
| There are n_training_iterations elements in the list. Each element is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #154.
This PR adds some type hints and doc comments to model_exploration.link_step_train_and_test_models, adds logging statements, and makes the output less chatty and more helpful. This step can take quite a while when the parameter grid to search is large, so the logging statements and print statements are really important for knowing how much progress it has made. The logging statements also give us timestamps, which can be helpful for finding and diagnosing performance issues.