hardware multicast address bugfix #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywc689
force-pushed
the
hw-mc-address-bugfix
branch
from
589d5e2
to
ec0a297
Compare
ywc689
added
the
pr/to-review-codes
ywc689
force-pushed
the
hw-mc-address-bugfix
branch
from
ec0a297
to
6762b6c
Compare
It takes long for some nics to update multicast ether addresses. The per-cpu process of per-cpu inetaddr causes mc ether address updating from both slave lcores and master lcore, which is nonsense but a dramatic hurt for performacne. So just do it once on master lcore. Signed-off-by: ywc689 <ywc689@163.com>
Signed-off-by: ywc689 <ywc689@163.com>
It has been noted that rte_eth_dev_set_mc_addr_list is of some restrictions: * The Api may be slow and take hundreds miliseconds. * Support only a very limited multicast ether address number. For instance of 25G Meallnox CX5, its PMD driver for rte_eth_dev_set_mc_addr_list supports only 128 multicast ether addresses for each port, and it takes about 250ms for rte_eth_dev_set_mc_addr_list to finish its work. Hence we make the following improvements: 1. Enable allmulitcast when rte_eth_dev_set_mc_addr_list failed, 2. Do not call rte_eth_dev_set_mc_addr_list when allmulitcast enabled. In next commmit, allmulticast can be configured at start of DPVS, which can solve the rte_eth_dev_set_mc_addr_list slow problem totally. Signed-off-by: ywc689 <ywc689@163.com>
…vices Signed-off-by: ywc689 <ywc689@163.com>
…packets out Signed-off-by: ywc689 <ywc689@163.com>
Signed-off-by: ywc689 <ywc689@163.com>
ywc689
force-pushed
the
hw-mc-address-bugfix
branch
from
f2adde1
to
4fc35b7
Compare
ywc689
added
pr/to-review-codes
you-looks-not-tasty
approved these changes
May 26, 2023
ywc689
added
pr/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.