Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compile error on RHEL 9.4 #966

Closed
wants to merge 1 commit into from
Closed

fix compile error on RHEL 9.4 #966

wants to merge 1 commit into from

Conversation

pubyun
Copy link
Contributor

@pubyun pubyun commented Jun 5, 2024

No description provided.

@@ -199,7 +199,11 @@ static int uoa_stats_percpu_show(struct seq_file *seq, void *arg)
unsigned int start;

do {
#if (RHEL_MAJOR == 9 && RHEL_MINOR < 4)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RHEL_MAJOR macro may be undefined in not-redhat system. You should use linux kernel version macro KERNEL_VERSION instead.
u64_stats_fetch_begin_irq() and u64_stats_fetch_retry_irq() got obsoleted since linux v6.3

@ywc689 ywc689 added the pr/codes-need-change problems found in the line-by-line code review and need to be fixed label Jun 11, 2024
@ywc689 ywc689 changed the base branch from master to devel June 11, 2024 10:20
@pubyun
Copy link
Contributor Author

pubyun commented Jun 20, 2024

RHEL系列(RHEL,CentOS,Almalinux等),都是保持大版本不变,只是将一些新的特性merge进来。这样使用 KERNEL_VERSION 就判断不出来。

RHEL 9.4 5.14.0-427.13.1.el9_4
RHEL 9.3 5.14.0-362.8.1.el9_3

@pubyun pubyun closed this by deleting the head repository Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/codes-need-change problems found in the line-by-line code review and need to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants