Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop cargo-xbuild build dependency #4

Closed
japaric opened this issue Jan 8, 2020 · 2 comments · Fixed by #14
Closed

drop cargo-xbuild build dependency #4

japaric opened this issue Jan 8, 2020 · 2 comments · Fixed by #14
Labels
upstream requires some changes in a upstream dependency (e.g. rustc)

Comments

@japaric
Copy link
Collaborator

japaric commented Jan 8, 2020

cargo-xbuild requires nightly and it's only reason building the examples requires nightly.

This tool is required because, currently, there's no bare metal Cortex-A support in rustc / rustup. (See rustc --print target-list & rustup target list). If we add support for this target to rustc / rustup (reference PR) then we'll be able to build all the code in this repo using a stable toolchain.

Hopefully, we should be able get that target support in by the 1.42 beta cutoff so all code will compile on the stable 1.42 release.
@japaric japaric added the upstream requires some changes in a upstream dependency (e.g. rustc) label Jan 8, 2020
@tarcieri
Copy link
Contributor

tarcieri commented Jan 8, 2020

That'd be great. In the meantime I think we're fine with nightly, but supporting stable would be quite nice.

@japaric
Copy link
Collaborator Author

japaric commented Jan 15, 2020

If we add support for this target to rustc / rustup

Submitted a PR: rust-lang/rust#68253

japaric added a commit that referenced this issue Jan 27, 2020
@japaric
drop cargo-xbuild build dependency; use plain Cargo
e0721ac 
closes #4
@japaric japaric mentioned this issue Jan 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream requires some changes in a upstream dependency (e.g. rustc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

drop cargo-xbuild build dependency iqlusioninc/usbarmory.rs
2 participants
@tarcieri @japaric