Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite iree/base/dynamic_library.h in C. #4642

Closed
benvanik opened this issue Jan 28, 2021 · 0 comments · Fixed by #5221
Closed

Rewrite iree/base/dynamic_library.h in C. #4642

benvanik opened this issue Jan 28, 2021 · 0 comments · Fixed by #5221
Assignees
@benvanik
Labels
hal/cpu Runtime Host/CPU-based HAL backend hal/vulkan Runtime Vulkan GPU HAL backend runtime Relating to the IREE runtime library
Projects
CUDA Backend

Comments

@benvanik
Copy link
Collaborator

It's C++ while it should be C. This will be used by both CUDA and Vulkan (which currently depends on it) as well as the dylib CPU loader.
@benvanik benvanik created this issue from a note in CUDA Backend (To do) Jan 28, 2021
@benvanik benvanik self-assigned this Jan 28, 2021
@benvanik benvanik added hal/cpu Runtime Host/CPU-based HAL backend hal/vulkan Runtime Vulkan GPU HAL backend runtime Relating to the IREE runtime library labels Jan 28, 2021
@benvanik benvanik added this to the 2021Q1 Core milestone Jan 28, 2021
@benvanik benvanik moved this from To do to In progress in CUDA Backend Jan 28, 2021
@benvanik benvanik mentioned this issue Jan 28, 2021
Closed
benvanik added a commit that referenced this issue Mar 24, 2021
@benvanik
Rewriting/simplifying DynamicLibrary in C.
207a141 
This allowed for a lot of file IO code to go away - there was needless
abstraction here as there was only a single user of a lot of these things
that was already platform-specialized.

Progress on #4369 and #3848.
Fixes #4642.
Unblocks #3845, which can now be added cleanly.
@benvanik benvanik mentioned this issue Mar 24, 2021
Merged
benvanik added a commit that referenced this issue Mar 24, 2021
@benvanik
Rewriting/simplifying DynamicLibrary in C.
33c45a2 
This allowed for a lot of file IO code to go away - there was needless
abstraction here as there was only a single user of a lot of these things
that was already platform-specialized.

Progress on #4369 and #3848.
Fixes #4642.
Unblocks #3845, which can now be added cleanly.

# Conflicts:
#	iree/hal/local/loaders/legacy_library_loader.c
benvanik added a commit that referenced this issue Mar 24, 2021
@benvanik
Rewriting/simplifying DynamicLibrary in C.
68ea3e8 
This allowed for a lot of file IO code to go away - there was needless
abstraction here as there was only a single user of a lot of these things
that was already platform-specialized.

Progress on #4369 and #3848.
Fixes #4642.
Unblocks #3845, which can now be added cleanly.

# Conflicts:
#	iree/hal/local/loaders/legacy_library_loader.c
benvanik added a commit that referenced this issue Mar 24, 2021
@benvanik
Rewriting/simplifying DynamicLibrary in C.
86d7fca 
This allowed for a lot of file IO code to go away - there was needless
abstraction here as there was only a single user of a lot of these things
that was already platform-specialized.

Progress on #4369 and #3848.
Fixes #4642.
Unblocks #3845, which can now be added cleanly.

# Conflicts:
#	iree/hal/local/loaders/legacy_library_loader.c
benvanik added a commit that referenced this issue Mar 24, 2021
@benvanik
Rewriting/simplifying DynamicLibrary in C.
c5b070e 
This allowed for a lot of file IO code to go away - there was needless
abstraction here as there was only a single user of a lot of these things
that was already platform-specialized.

Progress on #4369 and #3848.
Fixes #4642.
Unblocks #3845, which can now be added cleanly.

# Conflicts:
#	iree/hal/local/loaders/legacy_library_loader.c
benvanik added a commit that referenced this issue Mar 24, 2021
@benvanik
Rewriting/simplifying DynamicLibrary in C.
c45c361 
This allowed for a lot of file IO code to go away - there was needless
abstraction here as there was only a single user of a lot of these things
that was already platform-specialized.

Progress on #4369 and #3848.
Fixes #4642.
Unblocks #3845, which can now be added cleanly.

# Conflicts:
#	iree/hal/local/loaders/legacy_library_loader.c
benvanik added a commit that referenced this issue Mar 25, 2021
@benvanik
Rewriting/simplifying DynamicLibrary in C.
960d413 
This allowed for a lot of file IO code to go away - there was needless
abstraction here as there was only a single user of a lot of these things
that was already platform-specialized.

Progress on #4369 and #3848.
Fixes #4642.
Unblocks #3845, which can now be added cleanly.

# Conflicts:
#	iree/hal/local/loaders/legacy_library_loader.c
CUDA Backend automation moved this from In progress to Done Mar 25, 2021
benvanik added a commit that referenced this issue Mar 25, 2021
@benvanik
Rewriting/simplifying DynamicLibrary in C. (#5221)
46b31b0 
This allowed for a lot of file IO code to go away - there was needless
abstraction here as there was only a single user of a lot of these things
that was already platform-specialized.

Progress on #4369 and #3848.
Fixes #4642.
Unblocks #3845, which can now be added cleanly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benvanik benvanik

Labels
hal/cpu Runtime Host/CPU-based HAL backend hal/vulkan Runtime Vulkan GPU HAL backend runtime Relating to the IREE runtime library
Projects
No open projects
CUDA Backend
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewriting/simplifying DynamicLibrary in C. iree-org/iree
1 participant
@benvanik