Skip to content

Commit

Permalink
Use graceful-fs if available
Browse files Browse the repository at this point in the history
  • Loading branch information
@isaacs
isaacs committed Jun 26, 2015
1 parent 4f39b60 commit f09292b
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion glob.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,12 @@

module.exports = glob

var fs = require('fs')
var fs
try {
fs = require('graceful-fs')

This comment has been minimized.

Sign in to view

Copy link
@santanubasu

santanubasu Jun 27, 2015

This change references a dependency that I don't see in the package.json. Was that the plan, to have it be supplied externally? This seems to cause some issues when using browserify, probably there are ways to work around it, but I want to check that this is as designed first. thanks

This comment has been minimized.

Sign in to view

Copy link
@isaacs

isaacs Jun 27, 2015

Author Owner

Yeah, it was designed to be "use if available". I'm going to roll it back, though. Doesn't actually fix the problems.
} catch (er) {
fs = require('fs')
}
var minimatch = require('minimatch')
var Minimatch = minimatch.Minimatch
var inherits = require('inherits')
Expand Down

0 comments on commit f09292b

Please sign in to comment.