Use -TERM for pgroup kill, not negative pid

Either seems to work but the Ruby Process::kill docs only specify the negative signal form.
isabella232 · Apr 6, 2015 · 4b49e87 · 4b49e87
1 parent 19d7450
commit 4b49e87
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/posix/spawn/child.rb b/lib/posix/spawn/child.rb
@@ -160,8 +160,11 @@ def exec!
       rescue Object => boom
         [stdin, stdout, stderr].each { |fd| fd.close rescue nil }
         if @status.nil?
-          kill_pid = @pgroup_kill ? pid * -1 : pid
-          ::Process.kill('TERM', kill_pid) rescue nil
+          if !@pgroup_kill
+            ::Process.kill('TERM', pid) rescue nil
+          else
+            ::Process.kill('-TERM', pid) rescue nil
+          end
           @status = waitpid(pid) rescue nil
         end
         raise