Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mounting not working on iOS 12 #700

Closed
larrykollar opened this issue May 5, 2020 · 7 comments · Fixed by #732
Closed

Mounting not working on iOS 12 #700

larrykollar opened this issue May 5, 2020 · 7 comments · Fixed by #732

Comments

@larrykollar
Copy link

iPad Air, running iOS 12.4.6. Looks like the file picker is coming up instead of the directory picker.

iPad picker

Working as expected on an iPhone 6s, iOS 13.3.1.

@kkebo
Copy link
Contributor

kkebo commented May 5, 2020

It works on my 2nd generation 11" iPad Pro running iOS 13.5 beta 3.

image

@larrykollar
Copy link
Author

So maybe this only works in iOS 13+ ?

@tbodt
Copy link
Member

tbodt commented May 6, 2020

Sounds likely. I never tested on iOS 12.

@tbodt tbodt changed the title Mounting not working on iPad, OK on iPhone Mounting not working on iOS 12 May 6, 2020
@larrykollar
Copy link
Author

So does iOS 12 not support a directory picker?

@tbodt
Copy link
Member

tbodt commented May 6, 2020

Not sure, haven't looked into it. If that turns out to be the case, I'll disable the feature on iOS 12.

@kkebo
Copy link
Contributor

kkebo commented May 6, 2020

@larrykollar @tbodt It is possible to open a directory on iOS 12, but the UI is different from iOS 13. For example, Textastic and Pythonista has supported that feature since iOS 12.

@kkebo
Copy link
Contributor

kkebo commented May 17, 2020

@tbodt If UIDocumentPickerViewController.allowsMultipleSelection is set to YES, mounting will work even on iOS 11 and 12. But it requires a little more work for multiple selection. For example, ignore folders other than the first one.

C01680E7-2511-4954-A2F9-FC6C85A7FE9A

kkebo added a commit to kkebo/ish that referenced this issue May 23, 2020
kkebo added a commit to kkebo/ish that referenced this issue May 23, 2020
Mnpn pushed a commit to Mnpn/ish that referenced this issue Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants