Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard hiding/rotation broken by extra key hiding #753

Closed
tbodt opened this issue Jun 1, 2020 · 3 comments
Closed

Keyboard hiding/rotation broken by extra key hiding #753

tbodt opened this issue Jun 1, 2020 · 3 comments

Comments

@tbodt
Copy link
Member

tbodt commented Jun 1, 2020

Various reports from discord:
https://discord.com/channels/508839261924229141/508839261924229143/716818832370696233
https://cdn.discordapp.com/attachments/508839261924229143/716819380549451796/video0.mp4
https://cdn.discordapp.com/attachments/508839261924229143/716824325440798720/video0.mp4

The keyboard doesn't go away when the terminal resigns first responder. On iPhone (6s, 13.3.1), rotation is broken.
@yu90nusTr
Copy link

Me too (ios 13.3.1 ipad 7)

tbodt added a commit that referenced this issue Jun 1, 2020
@tbodt
Revert "Add a setting that hides extra keys with a HW keyboard"
554f0c4 
Broke various keyboard related behaviors (#753)

This reverts commit d7a915e.
@tbodt tbodt mentioned this issue Jun 1, 2020
Closed
@tbodt
Copy link
Member Author

tbodt commented Jun 2, 2020 •
edited
Loading

Revert is in, this issue now tracks fixing the actual problem

@tbodt
Copy link
Member Author

tbodt commented Jun 21, 2020

Should be fixed by 3c186de

@tbodt tbodt closed this as completed Jun 21, 2020
Mnpn pushed a commit to Mnpn/ish that referenced this issue Oct 22, 2020
@tbodt @Mnpn
Revert "Add a setting that hides extra keys with a HW keyboard"
3ba1d98 
Broke various keyboard related behaviors (ish-app#753)

This reverts commit d7a915e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tbodt @yu90nusTr