Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KVO crashes #1038

Merged
merged 2 commits into from
Nov 15, 2020
Merged

Fix KVO crashes #1038

merged 2 commits into from
Nov 15, 2020

Conversation

tbodt
Copy link
Member

@tbodt tbodt commented Nov 11, 2020

No description provided.

@tbodt tbodt requested a review from saagarjha November 11, 2020 08:08
@tbodt tbodt changed the title Automatically remove KVO observers on dealloc Fix problems with KVO observers not being removed on dealloc Nov 14, 2020
@tbodt tbodt changed the title Fix problems with KVO observers not being removed on dealloc Fix KVO crashes Nov 14, 2020
saagarjha
saagarjha reviewed Nov 14, 2020
View reviewed changes
Copy link
Member

@saagarjha saagarjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comments

app/NSObject+SaneKVO.m Show resolved Hide resolved
app/NSObject+SaneKVO.h Show resolved Hide resolved
app/NSObject+SaneKVO.h Show resolved Hide resolved
app/NSObject+SaneKVO.m Outdated Show resolved Hide resolved
app/Roots.m Outdated Show resolved Hide resolved
saagarjha
saagarjha reviewed Nov 14, 2020
View reviewed changes
app/NSObject+SaneKVO.h Outdated Show resolved Hide resolved
saagarjha
saagarjha reviewed Nov 14, 2020
View reviewed changes
app/NSObject+SaneKVO.h Outdated Show resolved Hide resolved
saagarjha
saagarjha reviewed Nov 15, 2020
View reviewed changes
Copy link
Member

@saagarjha saagarjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last couple things I noticed.

app/NSObject+SaneKVO.h Outdated Show resolved Hide resolved
app/Roots.m Outdated Show resolved Hide resolved
@tbodt tbodt merged commit cb10197 into master Nov 15, 2020
@tbodt tbodt deleted the kvo branch November 15, 2020 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saagarjha saagarjha saagarjha left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbodt @saagarjha