Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use multiline string for browser auth #23

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

Yagich
Copy link
Contributor

@Yagich Yagich commented Jun 22, 2023

currently, if the user tries to authenticate with Gift.authenticate(), the browser will open a malformed URL and return a 404 because the URL string contains multiple lines and indentation:

	OS.shell_open("https://id.twitch.tv/oauth2/authorize
	?response_type=code
	&client_id=" + client_id +
	"&redirect_uri=http://localhost:18297
	&scope=" + scope)

this PR fixes it by not using a multiline string. it's not the prettiest to be on one line, so if you'd like a better way to do it while keeping it free of tab characters and newlines i'm open to suggestions 🙂

@issork issork merged commit 7751bbf into issork:master Jun 23, 2023
@issork
Copy link
Owner

issork commented Jun 23, 2023

Thanks! ^^

@Yagich Yagich deleted the fix/no-multiline-string branch June 23, 2023 04:10
@issork issork mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants