-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage 0% #921
Comments
Im have a similar problem:
|
We require a link to a demo repository to be able to triage potential bugs. |
I'm seeing the same thing, but only in TravisCI. And I've got links! branch: https://github.com/articulate/paperplane/tree/lambda Would very much appreciate any ideas, because I'm unable to repro locally. It's only in TravisCI. |
Oh wow. Found the issue. Went back and looked at the Travis runs to see what changed between green and red, and since I was using latest before_install:
- npm install -g yarn@1.10.1 That seemed to fix it. Not sure what's up there, but it looks like |
@flintinatux I confirm it, magically nyc stopped working for me locally despite me dependencies were freezed. Then as a last try to solve impossible I tried to use this is my command: So probably this is |
Still broken with yarn |
I have the same issue here, it works fine with yarn <= 1.10.1, and it stops working after that. if I use npm or if I run nyc manually everything is fine. |
The plot thickens:
Gives no coverage, but it works with |
If you want to follow this on yarn side: |
Are people still experiencing this issue with the latest |
I'm experiencing the same issue, I don't use yarn. Reproduction case posted here: #822. |
@JaKXz Sadly, it still looks broken:
|
Hmm... Still looks like the signal is not passed on from |
Nevermind, totally works! Here is what I get when hard-codding the path to yarn:
|
I'm currently seeing something the other way around: Coverage at 0% when I run "nyc mocha test" but correct coverage when I run the script via npm (npm test where test is "nyc mocha test" in the package.json). nyc @ 13.1.0 in both cases. Interestingly, npm ls -g lists nyc as a dependency of npm?! Node.js 8.15.0, npm 6.4.1. Here's my npm ls (in my package) output:
|
@morris your issue sounds like it's different from the original... would you mind trying to reproduce it in a minimal example repo and opening a new issue when you do? Also, One minor thing, I hope you don't mind, I edited your comment for thread readability. @quentinvernot thank you for sharing! Are we satisfied to close this issue? |
Looks good to me, keep in mind that yarn's 1.13.0 is a pre-release, so it's not really fixed yet, but it was never nyc's fault in the first place. Up to you. |
Great, thanks! |
Just tried yarn |
@onehorsetown Okay, just upgraded my real yarn to 1.13.0 and removed my little hack with the hardcoded path, and... it doesn't work. If I keep the hardcoded path (with /usr/bin/yarn this time) it works though. It gets weirder, I made nyc run
And got this:
Here is the content of this
It's a new tmp file every time btw. It looks like yarn is doing this, no idea why so far... Probably don't reopen this issue, doesn't look like it's nyc's fault. |
symptomsI had the exact same problems:
setupI am using nyc with mocha to test native NodeJS code without any transpiler. npmI am using npm so this yarn issue didn't apply. I even updated npm locally (to nodeAnother difference between the CI environment and my local one was the NodeJS version.
Then I tested coverage with both versions and it seems like conclusionI don't know if the yarn bug from above is just another issue or it has something todo with node. If someone can confirm this issue with node |
This pins the version of node to 11.6.0 and yarn 1.12.3. node 11.7.0 or yarn 1.13.0 causes nyc to report 0% coverage. istanbuljs/nyc#921 yarnpkg/yarn#6746 circleci/node:11.6.0 Digest: sha256:1a3a10a092bdfa3d92d48850818a5526b5770a58592156f6f8e6a5f7d946ac43 Created 2019-01-18T00:14:29.784667795Z NODE_VERSION=11.6.0 YARN_VERSION=1.12.3
@jdoubleu It's a new issue that triggered by |
Can confirm that the same behavior occurs on |
I'm having the same issue with In reimplementing the 'testrunner' file that comes with
which use the functionality that was referenced here (nodejs/node#25650) with the |
also broken on |
also broken on lerna |
For me, it works on node v10.15 using NPM but not with yarn (v1.13.0). |
Same for me @wmenegali . Looks to be a yarn issue. |
still broken on |
Still facing the issue with yarn v1.16.0, using npm to run the tests like @worc suggested does the trick. |
yarn 1.17.3, nyc 14.1.1 - still the same problem |
Same here: yarnpkg/yarn#6746 (comment) |
this fixes istanbuljs/nyc#921 FINALLY
This solved my issue. |
not for me |
same issue, why the hell the ticket is closed? |
even worse when I hardcode the yarn path I get FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory |
Same issue here |
Are there any news regarding this issue? getting the error below:
|
is this closed for which reason? is the fix in another ticket? |
I had this error when I converted to ES6 modules. Reverting to CommonJS fixed the issue for me. |
I added
nyc
beforemocha
as the documentation suggests and it's giving 0% coverage.The text was updated successfully, but these errors were encountered: