Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove vestigial environment variables #1078

Merged
merged 1 commit into from
May 10, 2019

Conversation

isaacs
Copy link
Collaborator

@isaacs isaacs commented Apr 19, 2019

This removes the NYC_ROOT_ID and NYC_INSTRUMENTER environment variables, which are no longer used or necessary.

Probably best to leave NYC_CWD in place, since it's more load-bearing, and is sometimes inspected in user code to determine whether or not they're being covered by NYC.

Copy link
Member

@coreyfarrell coreyfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea but it needs to wait, we're not ready to merge breaking changes yet. I think we'll need to mark this as:

BREAKING CHANGE: Remove NYC_ROOT_ID and NYC_INSTRUMENTER environmental variables.
BREAKING CHANGE: The `root` field has been removed from processinfo files.

Although unlikely people are using these environment variables or the field of processinfo files they could be so I'd rather play it safe, just defer this change to 15.0.0.

This removes the NYC_ROOT_ID and NYC_INSTRUMENTER environment variables,
which are no longer used or necessary.

BREAKING CHANGE: Remove NYC_ROOT_ID and NYC_INSTRUMENTER environmental
variables.

BREAKING CHANGE: The `root` field has been removed from processinfo
files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants