[1.22] cni: properly cleanup completed pods (#51713) #51734
Merged
+89
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cni: properly cleanup completed pods Followup to istio#51429. When a pod is moved to terminal stage, we call RemovePodFromMesh. This has a variety of cleanup steps, and aborts early if any fail. Because the pod is terminated, we will fail to cleanup the in-pod rules. This is OK! The pod is terminated anyways. But with the current logic, this also means we do not send ztunnel the removed message, and it will leak proxy instances. Additionally, this does a variety of logging cleanups so that we consistently format messages and always show which pod we are acting on. * Address comments (cherry picked from commit 760ad26)
howardjohn
added
the
release-notes-none
istio-testing
added
the
size/L
howardjohn
changed the title
zirain
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51727