Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

substitute default ns for telemetryNs in yaml for prom install #51772

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

whitneygriffith
Copy link
Contributor

@whitneygriffith whitneygriffith commented Jun 27, 2024

Please provide a description of this PR:

The telemetryNamespace works as expected except for substituting the namespace of the subjects for the ClusterRoleBinding.

subjects:
  - kind: ServiceAccount
    name: prometheus
    namespace: istio-system

Replacing all instances of namespace: istio-system in the YAML before applying the configuration solves this. I hard coded istio-system as the user can change the systemNamespace variable and istio-system is set in samples/addons/prometheus.yaml

@whitneygriffith whitneygriffith requested a review from a team as a code owner June 27, 2024 18:10
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2024
@whitneygriffith whitneygriffith changed the title substitute telemetryNs for default ns in yaml for prom install substitute default ns for telemetryNs in yaml for prom install Jun 27, 2024
Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com>
@whitneygriffith whitneygriffith added the release-notes-none Indicates a PR that does not require release notes. label Jun 27, 2024
@istio-testing
Copy link
Collaborator

@whitneygriffith: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integ-helm_istio ee3ee6f link false /test integ-helm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@keithmattix
Copy link
Contributor

/retest-required

@istio-testing istio-testing merged commit cd8829f into istio:master Jun 27, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test and release release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants