Update protobuf to 455b61c6 (2017-05-08). #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to master branch, which includes a fix for cc_proto_library() to make it work in custom build environment (CC/CXX/LD_LIBRARY_PATH), see: protocolbuffers/protobuf#2508 Signed-off-by: Piotr Sikora <piotrsikora@google.com>
|
Note: alternatively, we could link against repo with v3.2.0 + this patch, but I'm not sure if there is any risk linking against master. |
qiwzhang
approved these changes
May 17, 2017
lizan
requested changes
May 17, 2017
| @@ -36,7 +36,7 @@ def boringssl_repositories(bind=True): | |||
| def protobuf_repositories(bind=True): | |||
| native.git_repository( | |||
| name = "protobuf_git", | |||
| commit = "593e917c176b5bc5aafa57bf9f6030d749d91cd5", # v3.2.0 | |||
| commit = "455b61c6b0f39ac269b26969877dd3c6f3e32270", # 2017-05-08 | |||
There was a problem hiding this comment.
v3.3.0 is released, with the change we needed, so just use that?
There was a problem hiding this comment.
v3.3.0 doesn't have this change.
lizan
approved these changes
May 17, 2017
|
#333 closes this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to master branch, which includes a fix for cc_proto_library() to
make it work in custom build environment (CC/CXX/LD_LIBRARY_PATH), see:
protocolbuffers/protobuf#2508