Fix yargs global options bypassing strict checks
#1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* #1272 done right * Needed because of yargs/yargs#873
0x2b3bfa0
added
bug
Test Comment |
Test Comment |
casperdcl
approved these changes
Jan 17, 2023
This was referenced Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this pull request, all the CML commands are broken when environment variables for some other commands are present.
--tokento--driver-token#1272 but done right1CML_OPTIONback toCML_COMMAND_OPTIONFootnotes
See Environment variables trigger errors for irrelevant commands (in strict mode) yargs/yargs#873 for context. ↩