Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 indexrst & readme updated for 12.0 #758

Merged
merged 24 commits into from Jul 30, 2019
Merged

📖 indexrst & readme updated for 12.0 #758

merged 24 commits into from Jul 30, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 11, 2019

No description provided.

@ghost ghost changed the title 📖 indexrst & readme updated 📖 indexrst & readme updated for 12.0 Jun 11, 2019
Copy link
Collaborator

@yelizariev yelizariev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the image is confusing. I'd say "No more reference to Odoo". But for this module it's better to make a screenshot of odoo backend, make the arrows to all "Odoo" references and state "Replace all Odoo reference to your Brand"

image

@@ -68,74 +68,27 @@ Removes references to odoo.com:
24. *(feature is not required in 12.0+ versions)*
25. *(feature is not required in 12.0+ versions)*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is duplicate for one in html and has to be deleted

* Form: https://www.it-projects.info/page/website.contactus
* Facebook: https://m.me/itprojectsllc
* Skype: skype@it-projects.info
Tested on Odoo 12.0 288662a9de7420deaf7b13c9a8b1b1b92e15ec1f
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file doesn't have Maintainer section as described in the guildelines https://odoo-development.readthedocs.io/en/latest/dev/docs/README.rst.html
Check other sections too

@@ -3,7 +3,7 @@
:alt: License: LGPL-3

====================
Backend debranding
Website debranding
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually Backend debranding

Auto-debrand new databases
==========================

To automatically install this module for every new databases set 'auto_install': True in **__openerp__.py** files of following modules:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openerp could be replaced to manifest (it's so since odoo 10)

<li> Replaces links to <a href="https://www.odoo.com/documentation"> documentation </a> (e.g. "Help" in Import tool, "How-to" in paypal, etc.) to custom website </li>
<li> Removes official videos in planner </li>
<li> Replaces "Odoo" in <i>application installed</i> mails </li>
</ul>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep a numbered list (use<ol> instead of <ul>). Also, keep removed items ("the feature is not needed since ...") -- it's allows to compare feature across different versions of the module

@ghost ghost closed this Jul 2, 2019
@ghost ghost reopened this Jul 2, 2019
<li> Replaces "odoo.com" in hints, examples, etc. </li>
<li> Rename "OdooBot" to "Bot". Use company's logo as bot avatar </li>
<li> [ENTERPRISE] Replaces icons for android and apple devices with custom url </li>
<li> Replaces links to <a href="https://www.odoo.com/documentation"> documentation </a> (e.g. "Help" in Import tool, "How-to" in paypal, etc.) to custom website </li>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second part of this message is ignored

 I'd like to keep a numbered list (use<ol> instead of <ul>). Also, keep removed items ("the feature is not needed since ...") -- it's allows to compare feature across different versions of the module

@yelizariev
Copy link
Collaborator

This is not a backend and the module may not replace odoo there

image

@ghost
Copy link
Author

ghost commented Jul 8, 2019

This is not a backend and the module may not replace odoo there

image

Со скриншотом проблемы, не понимаю, что показать в web_debranding

@yelizariev
Copy link
Collaborator

This is not a backend

image

@yelizariev
Copy link
Collaborator

This is backend
screenshot-569892-12-0-b6e7af runbot25 odoo com-2019 07 23-11_09_28


* Open *addons/mail/data/mail_data.xml* and edit Template **Notification Email** - delete ``using Odoo``
* Open *addons/website_livechat/data/website_livechat_data.xml* and edit in ``im_livechat_channel_data_website`` record *YourWebsiteWithOdoo.com* string
* Install ``website_debranding`` module if module *Website Builder* has been already installed in your system
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make a link to apps store

</p>
</div>
<div class="oe_row_img oe_centered">
<img class="oe_demo oe_picture oe_screenshot" src="debranding10.png"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that the picture is missing

* Install ``website_debranding`` module if module *Website Builder* has been already installed in your system
* Install ``pos_debranding`` module if module `POS` has been already installed in your system
* Install ``website_debranding`` `module <https://apps.odoo.com/apps/modules/10.0/website_debranding/>`__ if module *Website Builder* has been already installed in your system
* Install ``pos_debranding`` `module <https://apps.odoo.com/apps/modules/10.0/pos_debranding/>`__ if module `POS` has been already installed in your system
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link text should describe what is referenced to. "Module" is not the best option

@yelizariev yelizariev merged commit c38099e into itpp-labs:12.0 Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant