Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to waf 2.0.26 #953

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

nphilipp
Copy link
Contributor

This makes waf compatible with Python 3.12 again.

@falkTX
Copy link
Member

falkTX commented Aug 29, 2023

I was about to do this today, good timing!

There are some small changes to import though, regarding macOS versioning (need to keep it compatible with old releases)
Please import the waflib changes in 0f2e3b2 and dc6c995

we should probably combine these in a patch and keep it in the waflib dir, for the next time we need to update again...

@nphilipp
Copy link
Contributor Author

I’ll do that, but out of curiousity: isn’t it possible to integrate these changes upstream in waf so you don’t have to care about it any longer?

This makes waf compatible with Python 3.12 again.

Also, apply modifications needed for MacOS and add as a patch file (see
commits 0f2e3b2 and dc6c995).

Signed-off-by: Nils Philippsen <nils@tiptoe.de>
@falkTX
Copy link
Member

falkTX commented Aug 29, 2023

I’ll do that, but out of curiousity: isn’t it possible to integrate these changes upstream in waf so you don’t have to care about it any longer?

I dont think that is doable, this is a very special case due to previous jack2 builds being created using xcode in a very specific way (which used a single machine with a very specific setup too, which has since died) and then we moved macOS builds to using waf.

There were talks and even some initial code for switching to meson, as waf relying on python makes the build system break very easily..
So I do not think it is worth to bother waf developers with this, even more for a situation that is likely temporary

@falkTX falkTX merged commit 2504203 into jackaudio:develop Aug 29, 2023
9 checks passed
@falkTX
Copy link
Member

falkTX commented Aug 29, 2023

Thanks for PR! it is merged now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants