Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for section not containing heading element (W0012) #115

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

shamahdev
Copy link
Contributor

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This feature adds a warning to a <section> not containing heading element which it should be contained because a <section> doesn't has other specific semantic element to represent it. Resolves: #89

Link(s)

Screenshot(s)

image

Checklist:

  • I have thoroughly read the CONTRIBUTING guidelines.
  • I understand my pull request will be thoroughly reviewed at high detail.
  • I understand the work in my pull request will only be available in the next version release of Checka11y.css and not in the current version release.
  • I confirm the work in this pull request is valid according to my findings and is not something for anything personal.
  • I have updated the README and/or features.md where and if applicable (still put an x if you have considered this but thought there was nothing to add or modify).
  • I have added myself to the contributors section in package.json (still put an x if you have considered this but decided not to add yourself).
  • I have checked I have not committed any accidental files.
  • I have tested all the main modern browsers (I.e. Chrome, Firefox, Edge, Safari - please leave this unchecked if there were any browsers listed you could not test and list them in the help section with details why you couldn't test that browser)
  • I have run the automated tests and added new ones to cover new code.
  • All new and existing a11y checks still work correctly (compare your local test/index.html to the test/index.html in the master branch).

Help

I could not test in Safari because I do not have access to an Apple device.

@jackdomleo7 jackdomleo7 self-requested a review October 7, 2021 10:19
@jackdomleo7 jackdomleo7 added the a11y feature New feature or request for an a11y check label Oct 7, 2021
Copy link
Owner

@jackdomleo7 jackdomleo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job here! Just one minor thing I'd like adding 🙂

cypress/integration/section_spec.js Show resolved Hide resolved
src/warnings/features/_section.scss Show resolved Hide resolved
@jackdomleo7 jackdomleo7 added the Hacktoberfest Hacktoberfest eligible label Oct 7, 2021
Copy link
Owner

@jackdomleo7 jackdomleo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

@jackdomleo7 jackdomleo7 merged commit 36f99ca into jackdomleo7:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y feature New feature or request for an a11y check Hacktoberfest Hacktoberfest eligible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show a warning if a <section> does not have a heading element within it
2 participants