Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made sass a peer dependency #137

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Made sass a peer dependency #137

merged 1 commit into from
Oct 14, 2021

Conversation

jackdomleo7
Copy link
Owner

@jackdomleo7 jackdomleo7 commented Oct 14, 2021 •
edited
Loading

Enhancement/maintenance description

Why is this enhancement/maintenance important?

  • Lets developers know to use the Sass part of this project, they must install sass as a dependency

Covered test cases

Regression

Did you test on all major browsers?

I couldn't test Safari because I don't have access to an Apple device.

  • Chrome
  • Firefox
  • Edge
  • Safari

Other details

N/A

T&Cs

  • I confirm I have read and understand the contributing guidelines
  • I understand the work in this pull request will not be released straight away and will appear in a future release (if approved)
  • I confirm the work in this pull request is true and valid to the best of my knowledge
  • I have updated the README, features.md and codes.md files where applicable

@jackdomleo7 jackdomleo7 added the project enhancement Enhancement to improving the overall project label Oct 14, 2021
@jackdomleo7 jackdomleo7 self-assigned this Oct 14, 2021
@jackdomleo7 jackdomleo7 added this to In progress in Checka11y.css Kanban Board via automation Oct 14, 2021
@jackdomleo7 jackdomleo7 merged commit cbd1853 into master Oct 14, 2021
@jackdomleo7 jackdomleo7 deleted the 129_make_sass_a_peer_dependency branch October 14, 2021 20:11
Checka11y.css Kanban Board automation moved this from In progress to Done Oct 14, 2021
@jackdomleo7 jackdomleo7 added this to the v2 milestone Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackdomleo7 jackdomleo7

Labels
project enhancement Enhancement to improving the overall project
Projects
Checka11y.css Kanban Board
Done
Milestone
v2
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT]: Make Sass a peerdependency
1 participant
@jackdomleo7