Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace engines.npm with packageManager #169

Merged
merged 3 commits into from
Mar 25, 2023
Merged

Replace engines.npm with packageManager #169

merged 3 commits into from
Mar 25, 2023

Conversation

jackdomleo7
Copy link
Owner

Description

  • Resolve issue where consuming projects displayed a warning if they were not using npm 9. npm 9 is just the package manager being used within the project, consuming projects do not require it.

Why is this important?

  • False warnings are not good

Covered test cases

N/A

Did you test on all major browsers?

  • Chrome
  • Firefox
  • Edge
  • Safari

Other details

N/A


T&Cs

  • I confirm I have read and understand the contributing guidelines
  • I understand the work in this pull request will not be released straight away and will appear in a future release (if approved)
  • I confirm the work in this pull request is true and valid to the best of my knowledge
  • I have updated the README, features.md and codes.md files where applicable

@jackdomleo7 jackdomleo7 added the bug Something isn't working quite right label Mar 25, 2023
@jackdomleo7 jackdomleo7 self-assigned this Mar 25, 2023
@jackdomleo7 jackdomleo7 added this to In progress in Checka11y.css Kanban Board via automation Mar 25, 2023
@jackdomleo7 jackdomleo7 merged commit 48f09e8 into master Mar 25, 2023
Checka11y.css Kanban Board automation moved this from In progress to Done Mar 25, 2023
@jackdomleo7 jackdomleo7 deleted the npm-fix branch March 25, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quite right
Development

Successfully merging this pull request may close these issues.

None yet

1 participant