Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATE] - cypress to v13+ #172

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Conversation

elidakirigo
Copy link
Contributor

&template=project-enhancement.md

Description

this pull request contains an update of the cypress testing tool to v13+, added files cypress.config.js cypress/e2e/ , updated packeage.json and package.lock.json deleted cypress.json

why is this important?

this pull request solves the issue #167

Covered test cases

Did you test on all major browsers?

  • Chrome
  • Firefox
  • Edge
  • Safari

Other details

I would like this pull request to contribute towards my Hacktoberfest contributions

T&Cs

  • I confirm I have read and understand the contributing guidelines
  • I understand the work in this pull request will not be released straight away and will appear in a future release (if approved)
  • I confirm the work in this pull request is true and valid to the best of my knowledge
  • I have updated the README, features.md and codes.md files where applicable

@jackdomleo7 jackdomleo7 added Hacktoberfest Hacktoberfest eligible dependencies Pull requests that update a dependency file labels Oct 9, 2023
Copy link
Owner

@jackdomleo7 jackdomleo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks for contributing. However, the tests are appearing to be failing - see here.

I've also noticed that there are a lot of newly added files which seem to be the same as the existing files. Can we delete some duplicate files?

@elidakirigo
Copy link
Contributor Author

elidakirigo commented Oct 10, 2023

thanks, @jackdomleo7 for the feedback. here are the changes I've made

  • on the second commit I was testing out the GitHub CI on my repository (don't mind it)
  • on the last commit [FIX] - all test passing
    - I deleted the /cypress/integration folder which was duplicated to /cypress/e2e/ folder.
    - changed the before cypress function to beforeEach on all specs.
    - updated the readme.md file to match the new cypress version v13
    - updated .gitignore to avoid pushing my vscode personal setting, although it would be better to have .vscode/setting.json as this would specify the specific settings and not affect other shared vscode settings.
  • I did away with the /cypress/plugin folder, the code has been added to the cypress.config.js

Copy link
Owner

@jackdomleo7 jackdomleo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! Happy with your recent changes.

Good luck with the rest of Hacktoberfest 🎃

@jackdomleo7 jackdomleo7 merged commit a184fc5 into jackdomleo7:master Oct 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Hacktoberfest Hacktoberfest eligible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants