Skip to content

Commit

Permalink
Correctly handle offset queries on VectorSelector
Browse files Browse the repository at this point in the history
This fixes a regression added in #192 -- specifically that offsets
weren't being handled properly for VectorSelectors.
  • Loading branch information
jacksontj committed Sep 30, 2019
1 parent c2454bb commit 9ff65f2
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/proxystorage/proxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,7 @@ func (p *ProxyStorage) NodeReplacer(ctx context.Context, s *promql.EvalStmt, nod
if n.HasSeries() {
return nil, nil
}
removeOffset()

var result model.Value
var warnings api.Warnings
Expand All @@ -423,6 +424,7 @@ func (p *ProxyStorage) NodeReplacer(ctx context.Context, s *promql.EvalStmt, nod
for i, iterator := range iterators {
series[i] = &proxyquerier.Series{iterator}
}
n.Offset = offset
n.SetSeries(series, promhttputil.WarningsConvert(warnings))
n.DisableLookback = true

Expand Down

0 comments on commit 9ff65f2

Please sign in to comment.