Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel ast.Walk has errors with BinaryExpr #461

Closed
jacksontj opened this issue Sep 17, 2021 · 2 comments · Fixed by #550
Closed

Parallel ast.Walk has errors with BinaryExpr #461

jacksontj opened this issue Sep 17, 2021 · 2 comments · Fixed by #550
Labels

Comments

@jacksontj
Copy link
Owner

I was digging some more into #451 and it seems that there is some issue with parallel execution of ast.Walk specifically for BinaryExprs. Unfortunately I have no good lead at this point on what that may be but that was where I seemed to find an issue. Creating this to track a longer-term fix. For now I'll revert the parallel execution in the latest prom fork which I'm working to upgrade to (#460)

@jacksontj jacksontj added the bug label Sep 17, 2021
@jacksontj
Copy link
Owner Author

A note to myself; I found a few places in the promql engine that use the Inspect and path assuming a specific traversal order; so we'll have to modify the prom fork to handle the parallel execution.

@jacksontj
Copy link
Owner Author

WIP in jacksontj/prometheus#2

At this point I've fixed the data races; but still have one ordering issue in a test case.

jacksontj added a commit that referenced this issue Sep 21, 2021
jacksontj added a commit that referenced this issue Mar 8, 2023
jacksontj added a commit that referenced this issue Mar 9, 2023
jacksontj added a commit that referenced this issue Mar 9, 2023
jacksontj added a commit that referenced this issue Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant