Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct passing of Grouping/Without to count_values #284

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Correct passing of Grouping/Without to count_values #284

merged 1 commit into from
Mar 11, 2020

Conversation

jacksontj
Copy link
Owner

Previously count_values was dropping all Grouping labels in its
aggregation.

Fixes #283

@jacksontj
Correct passing of Grouping/Without to count_values
70383f4 
Previously `count_values` was dropping all Grouping labels in its
aggregation.

Fixes #283
@jacksontj jacksontj mentioned this pull request Mar 11, 2020
Closed
@jacksontj jacksontj merged commit 72f2586 into master Mar 11, 2020
@jacksontj jacksontj deleted the issue_283 branch March 11, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

count_values not returning correct labels when using by clause
1 participant
@jacksontj