Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AlertBackfill #613

Merged
merged 1 commit into from
Aug 19, 2023
Merged

Add AlertBackfill #613

merged 1 commit into from
Aug 19, 2023

Conversation

jacksontj
Copy link
Owner

@jacksontj jacksontj commented Aug 17, 2023 •
edited
Loading

TODO:

  • move to package
  • refactor to have a RuleFetcher:wrap the rule.Manager and have a mechanism to fetch based on matchers (extract name, compare labels)
  • create "promclient" which can use an engine to do the query
  • separate method which converts query_range output into the ALERTS_FOR_STATE series
  • tests
  • configuration

Found issues:

Fixes #50

@jacksontj jacksontj mentioned this pull request Aug 17, 2023
Closed
@jacksontj jacksontj force-pushed the issue_50 branch 2 times, most recently from 958f3f7 to d45f0f2 Compare August 19, 2023 04:21
@jacksontj
Add AlertBackfill functionality to promxy
7d7deea 
This optional config flag will enable promxy to backfill alert status by
re-querying the alert statement on startup -- in the event that the
downstream store doesn't have the corresponding ALERTS_FOR_STATE series.

Fixes #50
@jacksontj jacksontj marked this pull request as ready for review August 19, 2023 04:48
@jacksontj jacksontj merged commit 57d8ce4 into master Aug 19, 2023
1 check passed
@jacksontj jacksontj deleted the issue_50 branch August 19, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement "alert backfill" for promxy alerting rules
1 participant
@jacksontj