Correct OffsetFinder to handle "new" SubQuery support #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Offsetfinder is responsible to detemrine that the "tree" we are working on is at the same time offset. With the addition of SubQuery you can actually have an entire sub-tree at its own offset. Since subquery support was added (#246) we can actually allow NodeReplacer to run assuming the top of the tree is a SubQuery -- as we will "expand" it into its own tree.
jacksontj
force-pushed
the
issue_678
branch
from
3844a24
to
15b5883
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offsetfinder is responsible to detemrine that the "tree" we are working on is at the same time offset. With the addition of SubQuery you can actually have an entire sub-tree at its own offset. Since subquery support was added (#246) we can actually allow NodeReplacer to run assuming the top of the tree is a SubQuery -- as we will "expand" it into its own tree.
Fixes #678