Fix go tidy failure #685
Merged
Fix go tidy failure #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see the test case TestAddLabelClient is unstable. this is due to the labels order has been shuffled after convertions between []string and model.LabelSet, which is of map type.
Currently, the go mod tidy command is failing, and thus, we cannot update the vendors correctly. This is due to newer otel version has breaking changes in its cross-module internal code. This issue is reported in: open-telemetry/opentelemetry-go#4586 To fix it, we must specify a specific version of go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp So to fix: go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp@v1.18.0 go mod tidy && go mod vendor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the go mod tidy command is failing,
and thus, we cannot update the vendors correctly.
This is due to newer otel version has breaking
changes in its cross-module internal code.
This issue is reported in: open-telemetry/opentelemetry-go#4586
To fix it, we must specify a specific version of
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp
So to fix:
go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp@v1.18.0
go mod tidy && go mod vendor
Also, while pushing it, I noticed the test TestAddLabelClient is not stable,
This is due to the labels order has been
shuffled after convertions between []string
and model.LabelSet, which is of map type.
So I push the fix in a separate commit