Add more explicit logging RE recording rules #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Promxy doesn't currently support storing recording rules, because prometheus has no remote write API -- meaning promxy has no place to put the metrics. This used to log (before the 2.x upgrade)-- but that was dropped and this is confusing again. This patch adds 2 layers of logging. (1) in main it checks for recording rules on start (where it will fatal log) and on reload (error log) (2) the ProxyStorage.Appender() now also logs a warning. This will remain in place until #79 (the long term plan) is figured out and executed Fixes #74
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promxy doesn't currently support storing recording rules, because
prometheus has no remote write API -- meaning promxy has no place to put
the metrics. This used to log (before the 2.x upgrade)-- but that was
dropped and this is confusing again.
This patch adds 2 layers of logging. (1) in main it checks for recording
rules on start (where it will fatal log) and on reload (error log) (2)
the ProxyStorage.Appender() now also logs a warning. This will remain in
place until #79 (the long term plan) is figured out and executed
Fixes #74