Fix property dialog box incorrectly showing context menus for non combo widget types #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the code that creates and configures the widgets for the property dialog when double clicking a node, the block that sets up enum and combo properties was not surrounded in curly brackets, resulting in it always being executed no matter what the property type is.
The end result of it running the code for the combo widgets is that if you try to edit a number, string or any other type of property, it'll pop up an empty context menu which appears as a black box. After applying this change, it will no longer do this, and will allow users to edit properties without any visual errors.
This pull request has also included the changes from #201, as I accidentally branched from the same place, however, the changes in that PR are important too for users who use the minified build