Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing slider precision harcoded value #410

Merged
merged 3 commits into from
Jul 31, 2023
Merged

replacing slider precision harcoded value #410

merged 3 commits into from
Jul 31, 2023

Conversation

Guillaume-Fgt
Copy link
Contributor

#409

Following your answer @jagenjo , here is the PR. Thank you for your quick answer.

@jagenjo
Copy link
Owner

jagenjo commented Jul 31, 2023

instead of w.options.precision !== undefined
please use != null, as in your condition null would be a valid value.

@Guillaume-Fgt
Copy link
Contributor Author

For the combo case, the value is also checked using undefined. Do you want me to change this one too?

@jagenjo
Copy link
Owner

jagenjo commented Jul 31, 2023

no need, but you did the fix wrong, !== null means undefined is a valid value, just != null controls undefined and null as possible conditions.

@Guillaume-Fgt
Copy link
Contributor Author

thank you for you patience, I am not comfortable with JavaScript, still a lot to learn...

@jagenjo jagenjo merged commit 7e9518f into jagenjo:master Jul 31, 2023
@jagenjo
Copy link
Owner

jagenjo commented Jul 31, 2023

Thanks to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants