Add test coverage for declaring @Priority on producers #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moved from draft to ready for review as the proposal was approved and merged. |
Ladicek
reviewed
Nov 28, 2023
Ladicek
reviewed
Nov 28, 2023
|
Looks good on the first sight. I'll check with ArC (it should already work there) and report back. |
manovotn
force-pushed
the
issue498
branch
2 times, most recently
from
a643b16
to
a6bc2ba
Compare
Ladicek
approved these changes
Nov 28, 2023
|
ArC seems to pass these tests out of the box, which is good :-) |
manovotn
commented
Nov 30, 2023
...java/org/jboss/cdi/tck/tests/alternative/selection/priority/AltBeanProducingAlternative.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #498
This is aimed to cover the addition to the spec with the assumption that basics are already covered.
More precisely, using a comment depicting this from the original issue (jakartaee/cdi#556 (comment)), this PR aims to add coverage for
producer2,producer3,producer4andproducer8. The remaining scenarios were already possible prior to this change.Note that the test using
@Resourceproducer is in the web profile of TCK and amongst integration test group.This is a draft ATM because the related CDI PR isn't merged yet and because it hasn't been tested with any impl so far.