Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/improve parse host ports #149

Merged
merged 8 commits into from
Aug 1, 2024
Merged

Feat/improve parse host ports #149

merged 8 commits into from
Aug 1, 2024

Conversation

Catharsis68
Copy link
Contributor

  1. move parseHostPorts to utils
  2. Improve parseHostPorts
  3. Cover with test suite
    1. with hostports as string
    2. with hostports as array
    3. hostports without TLS
  4. Fix linting

@Catharsis68 Catharsis68 changed the title Feat/imrpove parse host ports Feat/improve parse host ports Jul 4, 2024
@davehorton
Copy link
Collaborator

can you rebase?

@Catharsis68
Copy link
Contributor Author

@davehorton merged latest main into the feature branch.

  • updated parseHostPorts and added obj.tcp = ${srf.locals.sipAddress}:5060;
  • Added the fix for the Contact header with enclosed angle brackets

@davehorton davehorton merged commit c270c0d into jambonz:main Aug 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davehorton davehorton davehorton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Catharsis68 @davehorton