Minor fixes for NumPy 2.0 compatiblity (rapidsai#746)

This MR resolves issues 3 and 4 reported [here](rapidsai#742 (comment)) when testing with NumPy 2.0 and CuPy 13.2 locally (issues 1 and 2 will be addressed in CuPy itself) rapidsai#742 (comment) For now, leave NumPy pinning as-is. Tests should continue to pass with NumPy 1.x Authors: - Gregory Lee (https://github.com/grlee77) Approvers: - https://github.com/jakirkham URL: rapidsai#746
jameslamb · Jul 11, 2024 · 540e96e · 540e96e
1 parent fbca7fa
commit 540e96e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/python/cucim/src/cucim/skimage/segmentation/_chan_vese.py b/python/cucim/src/cucim/skimage/segmentation/_chan_vese.py
@@ -429,6 +429,7 @@ def chan_vese(
         energies = []
     phivar = tol + 1
 
+    dt = cp.asarray(dt, dtype=float_dtype)
     while phivar > tol and i < max_num_iter:
         # Save old level set values
         oldphi = phi

diff --git a/python/cucim/tests/unit/core/test_stain_normalizer.py b/python/cucim/tests/unit/core/test_stain_normalizer.py
@@ -137,7 +137,7 @@ def test_result_value(self, image, expected):
                 stain_extraction_pca(image)
         else:
             result = stain_extraction_pca(image)
-            cp.testing.assert_allclose(result, expected)
+            cp.testing.assert_allclose(result, expected, rtol=1e-6)
 
 
 class TestStainNormalizerMacenko: