Add test for aws#622

This also will catch any groff warnings printed to stderr. Depends on: boto/bcdoc#27
jamesls · Feb 11, 2014 · 1d989f2 · 1d989f2
1 parent 4b35512
commit 1d989f2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/awscli/help.py b/awscli/help.py
@@ -88,7 +88,7 @@ def render(self, contents):
             raise ExecutableNotFoundError('groff')
         cmdline = ['groff', '-man', '-T', 'ascii']
         LOG.debug("Running command: %s", cmdline)
-        p3 = self._popen(cmdline, stdin=PIPE, stdout=PIPE)
+        p3 = self._popen(cmdline, stdin=PIPE, stdout=PIPE, stderr=PIPE)
         groff_output = p3.communicate(input=man_contents)[0]
         cmdline = self.get_pager_cmdline()
         LOG.debug("Running command: %s", cmdline)

diff --git a/tests/unit/docs/test_help_output.py b/tests/unit/docs/test_help_output.py
@@ -113,6 +113,12 @@ def test_add_help_for_dryrun(self):
         self.assert_contains('DryRunOperation')
         self.assert_contains('UnauthorizedOperation')
 
+    def test_elb_help_output(self):
+        self.driver.main(['elb', 'help'])
+        # We should *not* have any invalid links like
+        # .. _`:
+        self.assert_not_contains('.. _`:')
+
 
 class TestRemoveDeprecatedCommands(BaseAWSHelpOutputTest):
     def assert_command_does_not_exist(self, service, command):