forked from SeleniumHQ/selenium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ChromeDriver uses webdriver.chrome.getLocationInView atom to get location of an element, after scrolling it into view if necessary. This atom had a couple of bugs: 1. When this atom is passed the <html> element (i.e., document.documentElement), it throws an error since the parent node is not an element. This causes ChromeDriver bug https://crbug.com/chromedriver/1049. 2. Scrolling isn't working properly. This commit fixes both bugs, and expands the corresponding test. Signed-off-by: Alexei Barantsev <barancev@gmail.com>
- Loading branch information
Showing
3 changed files
with
44 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters