Skip to content

Commit

Permalink
Bug 1771516 [wpt PR 34235] - [FedCM] Re-enable network-based tests, a…
Browse files Browse the repository at this point in the history
…=testonly

Automatic update from web-platform-tests
[FedCM] Re-enable network-based tests

We had to disable these tests because due to how FedCM works, it needs
to make a request to the default HTTPS port (because to deter abuse, it
makes a request to the raw eTLD+1 host at the default port). This does
not directly work in wpt which runs a server at other ports.

This CL makes the test runner map web-platform.test:443 to port 8444,
making this work.

R=yigu@chromium.org

Bug: 1314987
Change-Id: I0683990aea724fc161d85c9bb9a84b80b6df4309
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3671447
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1008307}

--

wpt-commits: 85f8e58db43225ac10b86d25c9376d90c5b81e52
wpt-pr: 34235
  • Loading branch information
cbiesinger authored and moz-wptsync-bot committed Jun 9, 2022
1 parent 6f8d853 commit 55f2313
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
5 changes: 5 additions & 0 deletions testing/web-platform/tests/.well-known/fedcm.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"provider_urls": [
"https://web-platform.test:8444/credential-management/support/"
]
}
3 changes: 3 additions & 0 deletions testing/web-platform/tests/lint.ignore
Original file line number Diff line number Diff line change
Expand Up @@ -728,6 +728,9 @@ WEB-PLATFORM.TEST:web-bundle/resources/wbn/*.wbn
WEB-PLATFORM.TEST:web-bundle/subresource-loading/*.html
WEB-PLATFORM.TEST:web-bundle/subresource-loading/resources/*.js

# well-known file has hardcoded URLs
WEB-PLATFORM.TEST: .well-known/fedcm.json

# Tests that depend on resources in /gen/ in Chromium:
# https://github.com/web-platform-tests/wpt/issues/16455
# Please consult with ecosystem-infra@chromium.org before adding more.
Expand Down

0 comments on commit 55f2313

Please sign in to comment.