Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch OutOfMemoryError and set imageView GONE #237

Merged
merged 2 commits into from
Sep 14, 2019

Conversation

joeykrim
Copy link
Contributor

On a few devices, I've received an OutOfMemoryError exception crashing the app when setting the ImageResource.
Porposing to catch the out of memory exception and hiding the image rather than crashing the device.

On a few devices, I've received an OutOfMemoryError exception crashing the app when setting the ImageResource.
Porposing to catch the out of memory exception and hiding the image rather than crashing the device.
@CLAassistant
Copy link

CLAassistant commented Nov 24, 2017

CLA assistant check
All committers have signed the CLA.

@joeykrim
Copy link
Contributor Author

joeykrim commented Nov 25, 2017

travis ci build failed due to a configuration issue on the build instance: the license hasn't been accepted for ConstraintLayout v1.0.2

File /home/travis/.android/repositories.cfg could not be loaded.
Checking the license for package Solver for ConstraintLayout 1.0.2 in /usr/local/android-sdk/licenses
Warning: License for package Solver for ConstraintLayout 1.0.2 not accepted.
Checking the license for package ConstraintLayout for Android 1.0.2 in /usr/local/android-sdk/licenses
Warning: License for package ConstraintLayout for Android 1.0.2 not accepted.

FAILURE: Build failed with an exception.

  • What went wrong:
    A problem occurred configuring project ':app'.

Could not resolve all dependencies for configuration ':app:_debugApk'.
A problem occurred configuring project ':library'.
> You have not accepted the license agreements of the following SDK components:
[ConstraintLayout for Android 1.0.2, Solver for ConstraintLayout 1.0.2].
Before building your project, you need to accept the license agreements and complete the installation of the missing components using the Android Studio SDK Manager.
Alternatively, to learn how to transfer the license agreements from one workstation to another, go to http://d.android.com/r/studio-ui/export-licenses.html

@janheinrichmerker
Copy link
Owner

janheinrichmerker commented Apr 5, 2018

@joeykrim Could you please merge joeykrim#1 to fix issues with the Travis CI build?

@chimbori
Copy link
Collaborator

Hello, new maintainer here! Thanks for your PR; I realize that some time has passed since this PR was last proposed, so I certainly understand if you are no longer able to devote time to this, but if you are able to, I would love to see the comments addressed. Of course, I fully understand if you are not able to — could you please let me know either way? I am hoping to close any pending open PRs before cutting a new release. Thanks!

Fix Travis CI issues (merge changes from master)
@joeykrim
Copy link
Contributor Author

@joeykrim Could you please merge joeykrim#1 to fix issues with the Travis CI build?

Hello, new maintainer here! Thanks for your PR; I realize that some time has passed since this PR was last proposed, so I certainly understand if you are no longer able to devote time to this, but if you are able to, I would love to see the comments addressed. Of course, I fully understand if you are not able to — could you please let me know either way? I am hoping to close any pending open PRs before cutting a new release. Thanks!

Done - let me know if there's anything else to be done to merge

@chimbori chimbori merged commit 7f8f007 into janheinrichmerker:master Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants