-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix - mix of int and long #244
Conversation
Seems like Travis Ci is having some license issues, I'll try to get it to work later today. |
I've accepted the license while the check was running, don't know if I can retrigger travis? |
@MFlisar it's not because of the CLA but because of some Android support library licenses. |
you're right, did not read exactly enough... There's no need to hurry anyway |
I think once #242 is merged he can pull the changes and travis will succeed again. |
@meierjan I'm going to restart the Travis build. Let's see if it works out then. |
@heinrichreimer this branch needs to get the changes from the master to have a working build. @MFlisar can u do that? |
@MFlisar Could you please merge https://github.com/MFlisar/material-intro/pull/1 to fix issues with the Travis CI build? |
@heinrichreimer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getLong(ARGUMENT_ID)
is just consequent as all set-calls dosetLong(ARGUMENT_ID)
ARGUMENT_ID
is private so it can't be referenced outside of this class - can't brake anythinggetSlideId()
seems to be unused inside of this project - so this will brake nothing
Consideration:
getSlideId()
will brake builds for users (i.e. if they assign it to an int variable)
solves #243