Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: binary file lookup #1001

Merged
merged 2 commits into from
Aug 8, 2024
Merged

fix: binary file lookup #1001

merged 2 commits into from
Aug 8, 2024

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

  • After reduced build targets, need to fix the file lookup

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan requested a review from hiento09 August 8, 2024 09:37
@louis-jan louis-jan merged commit 59090bb into dev Aug 8, 2024
1 check passed
@louis-jan louis-jan deleted the fix/binary-lookup branch August 8, 2024 10:29
louis-jan added a commit that referenced this pull request Aug 8, 2024
@louis-jan @hientominh
fix: binary file lookup (#1001)
f1c8701 
Co-authored-by: Hien To <tominhhien97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiento09 hiento09 hiento09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louis-jan @hiento09 @hientominh