Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: persists engine version on init #969

Merged
merged 1 commit into from
Aug 5, 2024
Merged

fix: persists engine version on init #969

merged 1 commit into from
Aug 5, 2024

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

  • This PR is to persist the engine version and display it accordingly, instead of just returning a hardcoded version.
Screenshot 2024-08-04 at 22 16 03

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan mentioned this pull request Aug 4, 2024
Closed
3 tasks
@louis-jan louis-jan force-pushed the fix/persist-engine-version-on-init branch 2 times, most recently from 37ea747 to 99bb5a6 Compare August 4, 2024 16:00
@louis-jan louis-jan force-pushed the fix/persist-engine-version-on-init branch 2 times, most recently from 793f0dc to bf66b69 Compare August 5, 2024 07:47
@louis-jan louis-jan force-pushed the fix/persist-engine-version-on-init branch from bf66b69 to 4be4b5c Compare August 5, 2024 07:55
@louis-jan louis-jan merged commit b40100d into dev Aug 5, 2024
1 check passed
@louis-jan louis-jan deleted the fix/persist-engine-version-on-init branch August 5, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marknguyen1302 marknguyen1302 marknguyen1302 approved these changes

@namchuai namchuai Awaiting requested review from namchuai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-jan @marknguyen1302