Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove model selection in assistant tab model #3411

Merged
merged 1 commit into from
Aug 19, 2024
Merged

chore: remove model selection in assistant tab model #3411

merged 1 commit into from
Aug 19, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Aug 19, 2024

Describe Your Changes

  • Based on discuss with @imtuyethan confirmed we remove model selection on assistant tab

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur self-assigned this Aug 19, 2024
@github-actions github-actions bot added the type: chore Maintenance, integration, packaging related label Aug 19, 2024
louis-jan
louis-jan approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POOR YOU

@urmauur urmauur merged commit c441963 into dev Aug 19, 2024
9 checks passed
@urmauur urmauur deleted the chore/remove-assistant-tab-model-selection branch August 19, 2024 15:14
@github-actions github-actions bot added this to the v.0.6.0 milestone Aug 19, 2024
louis-jan pushed a commit that referenced this pull request Aug 20, 2024
@urmauur @louis-jan
chore: remove model selection in assistant tab model (#3411)
cc26fae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@Van-QA Van-QA Awaiting requested review from Van-QA

@marknguyen1302 marknguyen1302 Awaiting requested review from marknguyen1302

Assignees

@urmauur urmauur

Labels
type: chore Maintenance, integration, packaging related
Projects
Jan & cortex.cpp
Archived in project
Milestone
v.0.5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@urmauur @louis-jan